PFK Rewards
Round 5
@corollari#2127
15000
for continuing work on tbtcswaps.com and the aggregator! Impressing a ton of people in BTC land
Round 4
@corollari#2127
100000
Our top winners. For his work on ln2tbtc, a Lightning Network <> tBTC integration! Give it a try https://ln2tbtc.com/
Round 3
@corollari#2127
16500
Tier Two
Contribution
1.10.2020
tbtcswaps (previously ln2tBTC) is live on mainnet!
Apart from that, I've worked on a system that enables holders of KEEP that don't reach the staking threshold to pool together their KEEP and stake it. I expect that when the stakedrop begins we will see a big influx of new users that come because of the economic profits and are interested in participating without having to own large positions in KEEP, so this is meant to serve this market. Code: https://github.com/corollari/keep-staking-aggregator
Finally, I made two PRs to tbtc.js that aimed to improve several things that came up when I worked with it heavily last month to add TypeScript support & during a discussion with shadowfiend. The [main PR](https://github.com/keep-network/tbtc.js/pull/85) involved:
- Generate typescript typings (I'll deprecate my DefinitelyTyped package when the types are provided directly on the main package)
- Rework the tests and bring them back
- Transpile the readme to markdown to get it to show on npm (right now it's not getting recognized)
- Fix the example code provided on the README (it was outdated)
- A minor import fix
From discussion on this PR another one was spun (and it has already been merged, yay!), which fixes type-checks on CI (they were silently broken and a few type-incompatible changes slipped by). See https://github.com/keep-network/tbtc.js/pull/95 On top of that, my work on this lead me to land two PRs on alexbosworth's projects
1.09.2020
Contributions for this PFK:
- Created ln2tbtc.com, a swapping service that allows users to swap tBTC for Lightning Network-bound BTC trustlessly using submarine swaps and a decentralized network of liquidity providers
- Live page: https://ln2tbtc.com/
- Contract: https://github.com/corollari/ln2tBTC/blob/master/contract/contracts/LN2tBTC.sol
- Diagram of one of the protocols: https://raw.githubusercontent.com/corollari/ln2tBTC/master/images/ln2tbtc.svg
- Explanation of the protocol: https://github.com/corollari/ln2tBTC/blob/master/README.md
- Reported a bug on tbtc.js which made it to the previous release (and some others) and, if left unsolved, would have caused address synthesis to fail on mainnet. Curiously it turned out that the upstream dependency (bcoin) had also some outdated code surrounding that, so I also sent a PR there (https://github.com/bcoin-org/bcoin/pull/991).
- My PR: https://github.com/keep-network/tbtc.js/pull/73
- Commit that fixes the bug: https://github.com/keep-network/tbtc.js/commit/8baf5b6460fede068482890005b063b24397090e#diff-f6fe52647deaa287943ffff872ac9b6c
- I also reported some other bugs and added some types that were eventually merged (not by me), but given that there was a team member working in paralel on the same project I don't know if my efforts actually led to any changes. That is, given that these bugs were discovered doing static analysis it's quite possible that he didn't look at my PR, just did the same I did and we discovered the same things independentlywith with very little time difference (~days).
- Created
tbtcswaps (previously ln2tBTC) is live on mainnet!
- Check out https://tbtcswaps.com/ to swap tBTC for BTC on the lightning network trustlessly!
- If you'd like to become a liquidity provider, ping or send me a DM. Note: it involves running a lightning node
- If you are interested in security, try to break my implementation and get rewarded with 1k USD.
Apart from that, I've worked on a system that enables holders of KEEP that don't reach the staking threshold to pool together their KEEP and stake it. I expect that when the stakedrop begins we will see a big influx of new users that come because of the economic profits and are interested in participating without having to own large positions in KEEP, so this is meant to serve this market. Code: https://github.com/corollari/keep-staking-aggregator
Finally, I made two PRs to tbtc.js that aimed to improve several things that came up when I worked with it heavily last month to add TypeScript support & during a discussion with shadowfiend. The [main PR](https://github.com/keep-network/tbtc.js/pull/85) involved:
- Generate typescript typings (I'll deprecate my DefinitelyTyped package when the types are provided directly on the main package)
- Rework the tests and bring them back
- Transpile the readme to markdown to get it to show on npm (right now it's not getting recognized)
- Fix the example code provided on the README (it was outdated)
- A minor import fix
From discussion on this PR another one was spun (and it has already been merged, yay!), which fixes type-checks on CI (they were silently broken and a few type-incompatible changes slipped by). See https://github.com/keep-network/tbtc.js/pull/95 On top of that, my work on this lead me to land two PRs on alexbosworth's projects
run-lnd
and ln-service
. My changes are minor and not related to KEEP/tBTC at all, but still it's nice.1.09.2020
Contributions for this PFK:
- Created ln2tbtc.com, a swapping service that allows users to swap tBTC for Lightning Network-bound BTC trustlessly using submarine swaps and a decentralized network of liquidity providers
- Live page: https://ln2tbtc.com/
- Contract: https://github.com/corollari/ln2tBTC/blob/master/contract/contracts/LN2tBTC.sol
- Diagram of one of the protocols: https://raw.githubusercontent.com/corollari/ln2tBTC/master/images/ln2tbtc.svg
- Explanation of the protocol: https://github.com/corollari/ln2tBTC/blob/master/README.md
- Reported a bug on tbtc.js which made it to the previous release (and some others) and, if left unsolved, would have caused address synthesis to fail on mainnet. Curiously it turned out that the upstream dependency (bcoin) had also some outdated code surrounding that, so I also sent a PR there (https://github.com/bcoin-org/bcoin/pull/991).
- My PR: https://github.com/keep-network/tbtc.js/pull/73
- Commit that fixes the bug: https://github.com/keep-network/tbtc.js/commit/8baf5b6460fede068482890005b063b24397090e#diff-f6fe52647deaa287943ffff872ac9b6c
- I also reported some other bugs and added some types that were eventually merged (not by me), but given that there was a team member working in paralel on the same project I don't know if my efforts actually led to any changes. That is, given that these bugs were discovered doing static analysis it's quite possible that he didn't look at my PR, just did the same I did and we discovered the same things independentlywith with very little time difference (~days).
- Created
@types/keep-network__tbtc.js
on DefinitelyTyped so that it's much easier for other typescript users to get started (note that these types are better than what can be achieved by --declaration compiling with the current JSDoc comments, as declarations generated that way miss some things such as the types of class attributes)